View Topic

Amazing <3 thank you so much

So just putting this in here so it doesn't get lost in the Discord, but the system seems to not like the idea of self lynches, as it'll take me to a white screen every time and ignore saying that I posted on the main page...and most importantly doesn't record the vote.

Bug Fix: Message links (from notifications, etc.) go to wrong post
This was a very odd bug.

When Werewolf voting bugged out (you get the white screen), the forums weren't updating topic stats because the code that connects to the Werewolf system to count the vote was placed before the code that updated the topic stats. You would think this wouldn't impact viewing a topic, but it turns out that the forum uses the stat for number of replies to calculate which page a post should be on when you're going to a specific post. If that stat doesn't update that stat, then it throws the matching off. In this case, I found there were actually 10 more replies than the stat was showing. When I updated the stat from 296 to 306, the links started working correctly.

Even odder is that the forum only looks for posts up to the number of posts indicated in the stat. If the stat is less than the actual number of posts made, it doesn't show the amount of posts that's mismatched in the middle of the topic. This means that some posts would always be missing, but which ones were missing would shift as more posts were made. This may account for the missing posts that people have reported, and why in some cases they've shown up later, but I'll wait for confirmation from people affected by it before I declare that bug fixed. Regardless, when I updated the stat, the 10 missing posts also started appearing.

Interestingly enough, this is a variation of the same bug that afflicted Jurassic Park (in the book), in that their systems were only designed to count up to the number of dinosaurs they thought they had, so when the dinosaurs started breeding the system missed it. 

This issue also affected WW25, but it apparently went unnoticed. I've updated the number of replies for that topic to reflect 21 posts it wasn't counting, fixing the link issue there and presumably also revealing 21 missing posts in the middle of the topic.

Ultimately, the fix was moving the code that connected to the Werewolf system for vote casting to the end of the post function so that everything else is done first. You'll still get the white screen when it errors out (such as if you vote for yourself atm), but it shouldn't have any other impact on the forums or the game.

In addition to the bug fixes below, I also made some minor improvements to the post count table. There's now a total row for showing how many posts have been made in each round, and a total column showing how many total posts everyone as made throughout the entire topic. The table is also sorted in order of members with the most to least total posts made in the topic by default.

Bug Fixes

• Hosts could not kill players due to a bug where the game status check would always come back as not active
• Fixed issue with post counts where all posts made after the game started were placed in the latest round
• Fixed issue with post count table where round column widths could be inconsistent
• Fixed the bug with self-voting that Michi reported above

This is the first of three remaining updates I hope to make under Update 2. The way that hosts start the game, advance the round, and end the game has changed.

Games advance when the host makes some kind of posts, and the system now reflects this. In the past, hosts would click the appropriate button at the top of the screen, and game/phase start and end times would be recorded as of the time the host hit that button. However, hosts will now go to the post that marks the start of the game, start of the phase, or end of the game and click the button in that post. The game will record the time as of when the post was made. Reversing a phase is still done the same way as before, by clicking the button beside the round/phase indicator.

New Post-Based Host Options


This method is slightly more accurate, because previously if the host made a post to advance a phase and then clicked to advance the phase, the post would be included as part of the last phase. But beyond that, the system will now automatically create a bookmark when the game starts, the phase advances, or the game ends, meaning that the hosts no longer need to remember to do that. The bookmarks are created under the host that performed the action, so that host can manually go back to the post and delete the bookmark if desired for some reason.

In the process, I also created the game end ability, which didn't exist at all before tonight, then applied it to WW26 so that the post stats accurately reflected the posts made after the game ended.

Based!

Update 2/3:

Hosts can now add non-player voting options to their games. This may come in handy if you want to have a vote option besides one of the players in the game, perhaps an option that triggers an ability or an option that targets someone that isn't in the game as a player. These options are included and tabulated on the vote screen along with votes against players, no lynches, and unvotes.

You can add these options in the new Voting Options section of the Host Options screen. In that section are two fields: name, which is the text you want within the vote tags; and display, which specifies whether you want the option to show in the vote dropdown on the post page or not. By setting the display option to No, you can essentially create a secret option that players would have to experiment with and stumble upon.

Hosts can add voting options before the game starts or at any point during the game, allowing for options that only become available after a certain point.

Other Updates

• Unvote and No Lynch now appear in the vote dropdown.
• Bug Fix: The first player in a game did not show up on the vote dropdown.
• Bug Fix: Fixed an issue where using vote tags would trigger the white screen if the vote was not against a valid target